Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appreciate your feedback for custom element reactions diagram #74

Closed
AndyOGo opened this issue Feb 19, 2019 · 2 comments
Closed

appreciate your feedback for custom element reactions diagram #74

AndyOGo opened this issue Feb 19, 2019 · 2 comments

Comments

@AndyOGo
Copy link

AndyOGo commented Feb 19, 2019

I just released an adapted version of the interactive react lifecycle methods diagram for custom element reactions:
https://andyogo.github.io/custom-element-reactions-diagram/

If you have time, I would appreciate your feedback very much.

@eavichay
Copy link
Member

Look's good. I would split the constructor part into two cases: When an element is created by using some innerHTML of a wrapping element: the custom-element will have children, and when using it with document.createElement('my-elem') or new MyElement() which does not allow to populate anything (including attributes)

@AndyOGo
Copy link
Author

AndyOGo commented Feb 20, 2019

Fixed with:
AndyOGo/custom-element-reactions-diagram#19

And published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants