Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an end time placeholder to event templates. #60

Closed
slimndap opened this issue Oct 27, 2014 · 2 comments
Closed

Add an end time placeholder to event templates. #60

slimndap opened this issue Oct 27, 2014 · 2 comments
Labels
template
Milestone
v0.12

Comments

@slimndap
Copy link
Owner

Perhaps something like this:

{{datetime('end')}} and
{{datetime('end')|date('H:i')}}
@slimndap slimndap added this to the v0.9 milestone Oct 27, 2014
@slimndap slimndap modified the milestone: v0.9 Nov 28, 2014
@PieterKruithof
Copy link

Yes would like this. I use a 'endtime' custom field now with ACF plugin.
Could this also be {{endtime}} together with the existing {{time}}?
Or can I use {{datetime}} always like {{datetime('time')}} and {{datetime('date')}} and future {{datetime('end')}}?

@slimndap slimndap modified the milestone: v0.12 Jun 25, 2015
@slimndap
Copy link
Owner Author

Looks like @jbrandligt is working on this. See #136.

slimndap added a commit that referenced this issue Jun 26, 2015
@slimndap
Added tests that confirm the lack of support for {{starttime}}, {{sta…
ef1ea5a 
…rtdate}}, {{endtime}} and {{enddate}} placeholders.

See #60 and #136.
slimndap added a commit that referenced this issue Jun 28, 2015
@slimndap
Merge branch 'issue-60' into v0.12
bc1552e 
* issue-60:
  wpt_event.php is now PHP CodeSniffer approved.
  Improved the code of @jbrandligt: - Removed all PHP notices. - Fully deprecated WPT_Event::date() and WPT_Event::time(). - Complete the PHPDocs for the new methods.
  Startdate and enddate methods implemented too and some code cleanup. Date and and time methods are in fact identical to startdate_html and starttime_html methods but left for backward compatibility.
  Added tests that confirm the lack of support for {{starttime}}, {{startdate}}, {{endtime}} and {{enddate}} placeholders. See #60 and #136.
  Partial commit, starttime and endtime methods implemented, both text and html. startdate and enddate still to come.
  New approach on endtime method, work in progress...
  Add endtime field to wpt_events

Conflicts:
	functions/wpt_event.php
slimndap added a commit that referenced this issue Jun 28, 2015
@slimndap
Set the release date for v0.12.
e4077ad 
Fixes the HTML output for WPT_Event::datetime();
Closes #60.
@slimndap slimndap closed this as completed Jul 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
template
Projects
None yet
Milestone
v0.12
Development

No branches or pull requests
2 participants
@slimndap @PieterKruithof