Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra labels for SLO meta recordings #349

Open
SuperQ opened this issue Jul 14, 2022 · 0 comments
Open

Extra labels for SLO meta recordings #349

SuperQ opened this issue Jul 14, 2022 · 0 comments

Comments

@SuperQ
Copy link

SuperQ commented Jul 14, 2022

We use Thanos Ruler/Query to query data longer than 24h. In order to reduce fanout to different Prometheus instances, it would be useful to be able to inject extra labels on the SLO meta recording rules.

For example:

 slo:sli_error:ratio_rate30d{sloth_id=".,.",sloth_service="...",sloth_slo="..."}

Becomes:

 slo:sli_error:ratio_rate30d{prom_external_label="my_namespace",sloth_id=".,.",sloth_service="...",sloth_slo="..."}

I was thinking would only need to be a top-level spec key like extra_query_labels. We don't need this injected into the errorQuery or totalQuery, we do this on our side. But we need to manipulate the generated queries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants