https://github.com/smallnest/gen/issues/17 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
was fixed in the following jimsmart/schema#6 This is pulling the latest github.com/jimsmart/schema v0.0.0-20191104172732-39e4bec5335f which has the mssql.Driver mapped in. Further testing showed that there seems to be a difference between how mssql accepts a table from in the FROM statement. i.e. FROM Vehicle and NOT FROM `Vehicle` jimsmart/schema#10 To be backwards compatible with the jimsmart/schema library I am passing in the right table format based on the sqlType
|
The related issue, jimsmart/schema#10 has now been addressed, and v0.0.3 contains this fix. |
This was referenced Dec 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
was fixed in the following
jimsmart/schema#6
This is pulling the latest
github.com/jimsmart/schema v0.0.0-20191104172732-39e4bec5335f
which has the mssql.Driver mapped in.
Further testing showed that there seems to be a difference between how mssql accepts a table from in the FROM statement.
jimsmart/schema#10
To be backwards compatible with the jimsmart/schema library I am passing in the right table format based on the sqlType