Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please add "*mssql.Driver": &mssql, to dialect.go #6

Closed
ghstahl opened this issue Oct 31, 2019 · 1 comment
Closed

Please add "*mssql.Driver": &mssql, to dialect.go #6

ghstahl opened this issue Oct 31, 2019 · 1 comment

Comments

@ghstahl
Copy link
Contributor

ghstahl commented Oct 31, 2019

The problem is described in the referenced issue.
smallnest/gen#17

https://github.com/jimsmart/schema/blob/master/dialect.go#L32.
ghstahl added a commit to P7CoreOrg/schema that referenced this issue Oct 31, 2019
@ghstahl
https://github.com/jimsmart/schema/issues/6
fd50541
@jimsmart
Copy link
Owner

jimsmart commented Nov 4, 2019

Merged - thanks for the patch.

@jimsmart jimsmart closed this as completed Nov 4, 2019
ghstahl added a commit to ghstahl/gen that referenced this issue Nov 4, 2019
@ghstahl
https://github.com/smallnest/gen/issues/17
c2407c0 
was fixed in the following
jimsmart/schema#6

This is pulling the latest
	github.com/jimsmart/schema v0.0.0-20191104172732-39e4bec5335f
which has the mssql.Driver mapped in.

Further testing showed that there seems to be a difference between how mssql accepts a table from in the FROM statement.
i.e. FROM Vehicle and NOT FROM `Vehicle`

jimsmart/schema#10

To be backwards compatible with the jimsmart/schema library I am passing in the right table format based on the sqlType
@ghstahl ghstahl mentioned this issue Nov 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ghstahl @jimsmart