Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@Extension on pathParam is added to operation #376

Closed
tkalmar opened this issue Jun 23, 2020 · 1 comment · Fixed by #377
Closed

@Extension on pathParam is added to operation #376

tkalmar opened this issue Jun 23, 2020 · 1 comment · Fixed by #377

Comments

@tkalmar
Copy link

tkalmar commented Jun 23, 2020

When annotating an @Param with an @Extension the extension is generated at the wrong position in the yaml and json
adding

   @GET
    @Path("pathParamExtension/{param}")
    public String getParamWithExtension(@PathParam("param") @Extension(name = "x-operation-extension-3", value = "Operation extension wrapper value (3).") String param) {
        return "Path param extension value.";
    }

to io.smallrye.openapi.tck.extra.extensions.ExtensionResource and then

     @RunAsClient
        @Test(dataProvider = "formatProvider")
        public void testPathParamExtensions(String type) {
            ValidatableResponse vr = this.callEndpoint(type);
            String operation = "paths.'/extensions/pathParamExtension/{param}'.get";
            vr.body(operation + ".x-parameter-extension", nullValue());
            vr.body(operation + ".parameters[0].x-parameter-extension", equalTo("Operation extension wrapper value (3)."));
        }

to io.smallrye.openapi.tck.extra.ExtensionsTest demonstrates the wrong behaviour.

@tkalmar
Copy link
Author

tkalmar commented Jun 23, 2020

cc @famod

tkalmar pushed a commit to tkalmar/smallrye-open-api that referenced this issue Jun 23, 2020
tkalmar pushed a commit to tkalmar/smallrye-open-api that referenced this issue Jun 23, 2020
@MikeEdgar MikeEdgar linked a pull request Jun 24, 2020 that will close this issue
tkalmar pushed a commit to tkalmar/smallrye-open-api that referenced this issue Jun 27, 2020
tkalmar pushed a commit to tkalmar/smallrye-open-api that referenced this issue Jun 27, 2020
tkalmar pushed a commit to tkalmar/smallrye-open-api that referenced this issue Jun 27, 2020
tkalmar pushed a commit to tkalmar/smallrye-open-api that referenced this issue Jun 27, 2020
tkalmar pushed a commit to tkalmar/smallrye-open-api that referenced this issue Jun 27, 2020
tkalmar pushed a commit to tkalmar/smallrye-open-api that referenced this issue Jun 27, 2020
tkalmar pushed a commit to tkalmar/smallrye-open-api that referenced this issue Jun 27, 2020
tkalmar pushed a commit to tkalmar/smallrye-open-api that referenced this issue Jun 27, 2020
phillip-kruger added a commit that referenced this issue Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant