Fix for #376

[tkalmar]

this is a first try at fixing #376

[phillip-kruger]

@tkalmar Thanks for this. I think something went wrong with you PR, it shows 300+ file changes ?

[tkalmar]

@phillip-kruger reformat the PR so only the new files are actualy new ... now it even builds

[MikeEdgar]

I think this code should ultimately be in the ParameterProcessor where more context is known about the parameter. I noted that this approach may not work well outside of the basic situation where the only arguments to the resource method are non-form @*Param types.

We already have #267 dealing with @Extension, so perhaps this could be updated as well when that issue is fixed.

[MikeEdgar]

I don't think this approach is going to work outside of the basic scenario. I.e., the position in the operation's parameters may not always be the same as the position in the method parameters. Think of the case where @BeanParam is used or where parameters are injected into the resource class itself rather than as method arguments.

[phillip-kruger]

@MikeEdgar - Any suggestion on how @tkalmar can change the PR so that this will work better ?

[MikeEdgar]

@tkalmar , @phillip-kruger - I think a good approach would look something like this. I haven't tested this out :-)

1. io.smallrye.openapi.runtime.io.extension.ExtensionReader: overload readExtensions method, pass AnnotationScannerContext and List<AnnotationInstance>. Returns a Map<String, Object>, same as existing readExtensions by iterating over the List and creating a map entry for each list entry.
2. Pass AnnotationScannerContext from JaxRsAnnotationScanner to ParameterProcessor and set as an instance variable (the Index parameter can be removed and set the instance variable from the AnnotationScannerContext in the ParameterProcessor constructor. The calls from JaxRsAnnotationScanner can simply pass the context instead of context.getIndex().
3. Read the extensions in Parameter processor after the code for setDeprecated. Something like below. In this example, this.scannerContext is the new instance field from change (2) above.

List<AnnotationInstance> extensionAnnotations = ExtensionReader.getExtensionsAnnotations(context.target);

if (param.getExtensions() == null && !extensionAnnotations.isEmpty()) {
    param.setExtensions(ExtensionReader.readExtensions(this.scannerContext, extensionAnnotations));
}

Dismissing earlier approval in favor of the changes detailed above.

[MikeEdgar]

See earlier comments regarding changes in the ParameterProcessor

[tkalmar]

@phillip-kruger @MikeEdgar Thanks for the help, i extended the test to include one @BeanParam and it broke as expected. With the suggested changes it was a piece of cake to do the required changes. Test works now and is better than my first draft. Thanks a lot.

[MikeEdgar]

Looks good, thanks @tkalmar. Any concerns @phillip-kruger ?

[tkalmar]

Should this be backported at the 1.x branch to get it faster into quarkus or are there plans to switch quarkus to the 2.x branch in the near future?

[phillip-kruger]

Quarkus is on 2.x starting 1.6. we can try and get it in a.s.a.p. no need to backport.