Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore AirlinesAppTckTest #401

Merged
merged 1 commit into from
Jul 16, 2020
Merged

Conversation

jmini
Copy link
Contributor

@jmini jmini commented Jul 16, 2020

Related to issue #392.

One master (MicroProfile 1.x) the test is passing. This commits proves it and can be merged.

For MicroProfile 2.0 compliance, support for @SchemaProperty must be added, in order to pass this test.

Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You removed the test, not just the ignore part. Is that the intention ?

@jmini
Copy link
Contributor Author

jmini commented Jul 16, 2020

I must admit I am not familiar with how your @TckTest and BaseTckTest<T> works, but if we let the method empty it will be an empty test.

By comparison have a look at PetStoreAppTckTest:

@TckTest
public class PetStoreAppTckTest extends BaseTckTest<PetStoreAppTest> {
}

This is also empty.

Github actions does not seems to keep or to display tests result. But when I run locally I have a file:
tck/target/surefire-reports/TEST-org.eclipse.microprofile.openapi.tck.AirlinesAppTest.xml

With:

<?xml version="1.0" encoding="UTF-8"?>
<testsuite xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://maven.apache.org/surefire/maven-surefire-plugin/xsd/surefire-test-report.xsd"
 name="org.eclipse.microprofile.openapi.tck.AirlinesAppTest" time="13.718" tests="90"
 errors="0" skipped="0" failures="0">
  <properties>
...

@MikeEdgar
Copy link
Member

This change is correct. Once the pom is updated to MP 2.0 with @jmini 's other branch, this test will start to fail until SchemaProperty is implemented.

@jmini
Copy link
Contributor Author

jmini commented Jul 16, 2020

Once the pom is updated to MP 2.0 with @jmini 's other branch, this test will start to fail until @SchemaProperty is implemented.

Which is all good.

If SmallRye is used to validate that the MP-OpenAPI Tck is valid, then we need to have it implemented. (personally I have no time to look at it).

@phillip-kruger phillip-kruger merged commit 05b10d6 into smallrye:master Jul 16, 2020
@phillip-kruger phillip-kruger added this to the 2.0.4 milestone Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants