Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocert + sidecar proxy #33

Open
etiennejournet opened this issue Apr 27, 2021 · 2 comments
Open

Autocert + sidecar proxy #33

etiennejournet opened this issue Apr 27, 2021 · 2 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@etiennejournet
Copy link

Hey all ! I wonder if you would consider adding a sidecar proxy to the feature list of Autocert.

I was thinking that :

  • on an annotation (autocert.step.sm/inject: true), the operator could add the sidecar (e.g envoy) and provide certificates.
  • The sidecar pod mount certificates, takes on network and does TLS proxy passthrough
  • Optionnaly, the proxy is able to refresh itself when certs are renewed

This is very close to service-mesh I know, but LOT more simple and could resolve use cases in which the application cannot present certificates or auto-refresh when certificates are renewed.
Both ways (with sidecar/without sidecar) could still work together.

I might be interested to contribute on that If you consider it worth/doable.

Regards,

@etiennejournet etiennejournet added enhancement New feature or request needs triage Waiting for discussion / prioritization by team labels Apr 27, 2021
@dopey
Copy link
Contributor

dopey commented Apr 27, 2021

Hey @etiennejournet, thanks for opening the issue! Discussed this morning with the team so I'll try to do a brain dump of our discussion.

tl;dr We think it's best to implement a sidecar proxy as a separate project. We'd be very willing to add hooks / make modifications to autocert to support such a project.

Autocert is intended to do one thing well - generate cert and place said cert in a pod. If we add even the most simple proxy we'll have to ...

  • decide on a proxy (nginx, traefik, envoy, etc.), we don't want to get political
  • (if it becomes popular) increase surface area of proxy configuration as new feature requests come in.
    Rather than manage a proxy from within Autocert, we'd much prefer said side-car proxy be a separate project. We'd be happy to expose hooks and configuration in Autocert configuration to make it easy to combine with a sidecar. If you're interested in such a project, we'd be happy to help with spec-ing and any integration questions.

cheers!

@dopey dopey added wontfix This will not be worked on and removed needs triage Waiting for discussion / prioritization by team labels Apr 27, 2021
@etiennejournet
Copy link
Author

Thanks for your honest response ;) I will get back to you if I decide to do something ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants