Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IID provisioners get "0s" instance age by default #98

Open
mmalone opened this issue Aug 29, 2019 · 3 comments
Open

IID provisioners get "0s" instance age by default #98

mmalone opened this issue Aug 29, 2019 · 3 comments

Comments

@mmalone
Copy link
Contributor

mmalone commented Aug 29, 2019

When I run step ca provisioner add aws --type AWS --aws-account XXXX I end up with a provisioner configuration that has "instanceAge": "0s". In other words, default instanceAge is “0s”. That ends up meaning “don’t enforce instance age”, which is weird.

I figure that “0s” is the default value for whatever the duration object is in golang… so it’s probably hard to distinguish between “0s” and the value simply not being defined in configuration… but it still feels weird. Is there anything easy we can do to make this more intuitive?

@maraino
Copy link
Contributor

maraino commented Aug 30, 2019

To solve this we'll need to change that kind of types to pointers.

@dopey
Copy link
Contributor

dopey commented Nov 18, 2020

@maraino did this ever get fixed?

@maraino
Copy link
Contributor

maraino commented Nov 18, 2020

No, but 0s does not cause any issue other than "cosmetic".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants