Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include erroring Pilet name with ErrorInfoProps where applicable #477

Closed
EclipseZA opened this issue Feb 17, 2022 · 3 comments
Closed

Include erroring Pilet name with ErrorInfoProps where applicable #477

EclipseZA opened this issue Feb 17, 2022 · 3 comments
Labels
core Concerns the piral-core library. enhancement New feature or request
Milestone
0.14.11

Comments

@EclipseZA
Copy link

New Feature Proposal

Description

Include the name of the erroring Pilet with ExtensionErrorInfoProps and PageErrorInfoProps when error info to the SwitchErrorInfo component.

Background

When a Page or Extension error occurs, we would like to log the error so the relevant Pilet team can fix it.
Currently, there doesn't seem to be a way to get the name of the Pilet that caused the error, and I wasn't able to extend this functionality to do so.

Discussion

Examining the source code of the ErrorBoundary component (src/framework/piral-core/src/components/errorboundary), I can see the name of the Pilet is available, as it is logged to console.
It would be great if that can be included with the props sent to the SwitchErrorInfo component.
@EclipseZA EclipseZA added the enhancement New feature or request label Feb 17, 2022
@FlorianRappl FlorianRappl added the core Concerns the piral-core library. label Feb 17, 2022
@FlorianRappl FlorianRappl added this to the 0.14.11 milestone Feb 17, 2022
@FlorianRappl FlorianRappl added in-implementation The item is currently being implemented. in-testing The item is already out in preview and can be tested. and removed in-implementation The item is currently being implemented. labels Feb 17, 2022
@FlorianRappl
Copy link
Contributor

This is available in develop and should be out in the next version in about 25-30 min.

@EclipseZA
Copy link
Author

Thanks for the quick update.

@FlorianRappl
Copy link
Contributor

This is working as intended. Will be released with the 0.14.11.

@FlorianRappl FlorianRappl removed the in-testing The item is already out in preview and can be tested. label Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Concerns the piral-core library. enhancement New feature or request
Projects
None yet
Milestone
0.14.11
Development

No branches or pull requests
2 participants
@FlorianRappl @EclipseZA