Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piral-Cli uses deprecated package #684

Closed
3 tasks done
fsdschmidt opened this issue Apr 5, 2024 · 2 comments
Closed
3 tasks done

Piral-Cli uses deprecated package #684

fsdschmidt opened this issue Apr 5, 2024 · 2 comments
Labels
invalid This doesn't seem right

Comments

@fsdschmidt
Copy link

Bug Report

For more information, see the CONTRIBUTING guide.

Prerequisites

  • Can you reproduce the problem in a MWE?
  • Are you running the latest version?
  • Did you perform a search in the issues?

Environment Details and Version

piral-cli: 1.5.2

Description

Our pipeline job installs current piral-cli for our shell build. Starting recently, our pipeline is unable to install piral-cli package, because one of the dependencies uses deprecated querystring lib. Please upgrade piral-cli to the recommended URLSearchParams.

$ npm i piral-cli -g
added 48 packages in 8s
8 packages are looking for funding
  run `npm fund` for details
$ npm i
npm WARN deprecated querystring@0.2.1: The querystring API is considered Legacy. new code should use the URLSearchParams API instead.

Steps to Reproduce

  1. remove querystring from npm cache
  2. npm i piral-cli -g

Expected behavior

Npm installs current piral-cli package version.

Actual behavior

Npm stops piral-cli package installation with warning. As a workaround we are able to install with --force.

Possible Origin/Solution

Inspect dependencies and raise version of dependency which uses querystring lib.

@fsdschmidt fsdschmidt added the bug Something isn't working label Apr 5, 2024
@FlorianRappl
Copy link
Contributor

The piral-cli library is not using querystring.

https://github.com/smapiot/piral/blob/develop/src/tooling/piral-cli/package.json

So not sure what you are seeing / your system is reporting.

If I look at the code you've provided then I see that the npm i -g piral-cli installs without warnings. So the problem is in your npm i (not sure where this is running - the only dependency using querystring in this code base is piral-cli-webpack5).

@FlorianRappl FlorianRappl added invalid This doesn't seem right and removed bug Something isn't working labels Apr 5, 2024
@fsdschmidt
Copy link
Author

Ok, thanks for your hint, we will investigate our npm setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants