fix RebenchLog case; error on missing gauge adapter #200
Conversation
|
I left a TODO in the code: execution should exit as soon as reasonable if no gauge adapter can be decided on. There's no precedent in the code, and I'm not sure what needs cleaning up. Is |
| # obtain gauge adapter module from provided name or die trying | ||
| gauge_adapter_name = run_id.get_gauge_adapter_name() | ||
| gauge_adapter = self._get_gauge_adapter_instance(gauge_adapter_name) | ||
| if gauge_adapter is None: | ||
| run_id.fail_immediately() | ||
| msg = "{ind}Couldn't find gauge adapter: %s\n" % gauge_adapter_name | ||
| self.ui.error(msg, run_id) | ||
| # TODO exit early here (how?) |
There was a problem hiding this comment.
#202 is best! Please add it there.
I do like that you fail the What might be annoying is to get a hundred error messages that are the same. Perhaps we want to keep a dictionary of adapter names we already warned about. |
|
I think this should be dropped in favour of #202 (and the docs tweaks/error messages can be added on over there). I'll give it a close for now. |
Addresses #199 . Fixes the case of the
RebenchLoggauge adapter and adds some notes on case sensitivity in relevant places. In the gauge adapter resolver, we emit an error message for missing gauge adapters instead of leaving it to the Python stack trace.