Make gauge adapter names in configuration case insensitive #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move the logic into adapter.py for easier testing and to move responsibility out of executor Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
|
Hadn't realized that's how it worked. Yeah this is much nicer, now Linux will have the same behaviour as the other case-insensitive platforms. |
|
Merged. Thanks! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I looked at the loading code again, I noticed that we already traverse the module and load everything to find the adapter we are looking for.
So, this really just needs to add a bit of logic to make the check case insensitive.
Also used the chance the move the logic where it belongs, into the interop package, and add tests.
@raehik is this what you were hoping for?
This fixes #199.