Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create individual classes for Date, DateTime, Time and Instant #11

Closed
p2 opened this issue Apr 11, 2016 · 1 comment · Fixed by #164
Closed

Create individual classes for Date, DateTime, Time and Instant #11

p2 opened this issue Apr 11, 2016 · 1 comment · Fixed by #164
Labels
bug

Comments

@p2
Copy link
Member

p2 commented Apr 11, 2016

Currently, these are all served by FHIRDate. Would be nice to distinguish those.
@mikix
Copy link
Contributor

mikix commented Jul 18, 2024 •
edited
Loading

It's worth noting that this isn't just a nice-to-have. There are real bugs because of this:

  • we don't parse time fields correctly (could be fixed by adding special detection)
  • but we also mistakenly accept an instant-formatted string in a date field. Because FHIRDate doesn't know what type of field it's supposed to be parsing.

@mikix mikix added the bug label Jul 18, 2024
@mikix mikix mentioned this issue Jul 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Overhaul how date & time parsing works. smart-on-fhir/client-py
2 participants
@p2 @mikix