Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need SNI support in client #9

Closed
nschwertner opened this issue Mar 23, 2016 · 1 comment
Closed

Need SNI support in client #9

nschwertner opened this issue Mar 23, 2016 · 1 comment

Comments

@nschwertner
Copy link
Member

It looks like Requests (used in the Python client) needs some additional modules in order to support SNI (we have multiple certificats served on the same IP). https://stackoverflow.com/questions/18578439/using-requests-with-tls-doesnt-give-sni-support/18579484#18579484 Otherwise, the client throws an SSLError (hostname 'stub.smarthealthit.org' doesn't match either of '*.smartplatforms.org', 'smartplatforms.org') when pointed at a API server that is on a host with multiple certificates.

The test case is running any Python-based sample app against https://stub.smarthealthit.org/smart/dstu2 (for example using the launcher at https://stub.smarthealthit.org/). This service will not work for self-launched apps that ask for context. Works for apps that are launched in context (via the launcher at https://stub.smarthealthit.org/ or similar) and with apps that don't need context. The sample app that comes with the Python client is a standalone app that needs context assigned after launch, so not good for testing. We have another sample app that needs to be launched in context and should work for testing purposes: https://github.com/smart-on-fhir/sample-apps/blob/master/rest-app/app.py

@p2
Copy link
Member

p2 commented Apr 7, 2016

As discussed, this is fixed on the Python level with Python 2.7.9+ and in Python 3.

@p2 p2 closed this as completed Apr 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants