Added ability to tune to any numeric channel, play, pause and stop functions to media player. #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert and fixes 1 when merging 6fade2c into 2e51a3e - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request introduces 1 alert and fixes 1 when merging 8e6a191 into 96e29f6 - view on LGTM.com new alerts:
fixed alerts:
|
functions to media_player.py # Please enter the commit message for your changes. Lines starting
|
+1 for this |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the support for changing channels now available in the Alexa component, the additions of these extra functions in media_play.py will now allow a user to say "Alexa, tune to channel 125 on TV" or say "Alexa tune to CityTV on TV" , or "Alexa, Pause DVR", etc. The functions will then send the appropriate digits sequentially to the selected controller.
The changes needed in the codes files to support this require the addition of codes for each individual key. ie key_0, key_1, key_2, enter,play,pause,stop, etc in the commands section.
Optionally, the addition of a channels subsection will add the ability to tune by channel name from Alexa. ie: "channels": {
"city": "7",
"citytv": "7",
"pulse24": "24",
"amc": "31",
}