Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a sound mode selector #911

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

glebsterx
Copy link
Contributor

Adds a sound_mode list that will allow these modes to be controlled on audio systems and audio receivers until the media player is put into standby or turned off. Made by analogy with source_list, but with one caveat: by default, the GUI selector "Sound mode" does not disappear when the media player is turned off, so this feature is removed from supported_features every time it is turned off (because it is illogical to control the sound mode of a turned off device)

Adds a sound_mode list that will allow these modes to be controlled on audio systems and audio receivers until the media player is put into standby or turned off. Made by analogy with source_list, but with one caveat: by default, the GUI selector "Sound mode" does not disappear when the media player is turned off, so this feature is removed from supported_features every time it is turned off (because it is illogical to control the sound mode of a turned off device)
@stale
Copy link

stale bot commented Sep 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 21, 2022
@stale stale bot removed the stale label May 22, 2024
@glebsterx
Copy link
Contributor Author

Almost 2 years have passed, and I consider the test passed and successful, because I use the component with the modification from this PR every day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant