Normalize ref regex (#13112)

smartcontractkit · May 6, 2024 · 8059066 · 8059066
1 parent 466d161
commit 8059066
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/ten-dodos-run.md b/.changeset/ten-dodos-run.md
@@ -0,0 +1,5 @@
+---
+"chainlink": patch
+---
+
+#internal Normalize keystone workflow ref regex property to match id regex
diff --git a/core/services/workflows/models_yaml.go b/core/services/workflows/models_yaml.go
@@ -211,7 +211,7 @@ type stepDefinitionYaml struct {
 	//  - “ref” has a circular reference.
 	//
 	// NOTE: Should introduce a custom validator to cover trigger case
-	Ref string `json:"ref,omitempty" jsonschema:"pattern=^[a-z0-9_]+$"`
+	Ref string `json:"ref,omitempty" jsonschema:"pattern=^[a-z0-9_-]+$"`
 
 	// Capabilities can specify an additional optional ”inputs” property. It allows specifying a dependency on the result of one or more other capabilities. These are always runtime values that cannot be provided upfront. It takes a map of the argument name internal to the capability and an explicit reference to the values.
 	//

diff --git a/core/services/workflows/testdata/fixtures/workflows/workflow_schema.json b/core/services/workflows/testdata/fixtures/workflows/workflow_schema.json
@@ -48,7 +48,7 @@
         },
         "ref": {
           "type": "string",
-          "pattern": "^[a-z0-9_]+$"
+          "pattern": "^[a-z0-9_-]+$"
         },
         "inputs": {
           "$ref": "#/$defs/mapping"