Interfaces and skeleton methods for ChainReader EVM POC #10990

reductionista · 2023-10-18T02:44:25Z

This is the first step toward implementing the EVM POC plan described here:
https://www.notion.so/chainlink/Scope-of-Generalized-ChainReader-POC-1957107ecfc44c359edce081ef426d1d

This POC is based on the more general specs described in the ChainReader CLIP:
https://github.com/smartcontractkit/CLIPs/tree/2023-06-31-chain-reader/clips/2023-08-25-chain-reader

Requires:

All 4 of the above PR's must be merged first in order for this one to compile.

github-actions · 2023-10-18T02:44:46Z

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

core/services/relay/evm/chain_reader.go

.github/workflows/integration-tests.yml

core/services/ocr2/plugins/median/services.go

core/services/relay/evm/chain_reader.go

… POC - Read ChainReader config in from RelayConfig - Add some initialization and validation relay skeletons - Use medianProviderWrapper instead of passing medianContract separately This avoids us having to modify the signature of NewMedianFactory, which would require further modifications to all non-evm repos and chainlink-relay - Add chain_reader_test.go with some basic relay tests Co-authored-by: Jordan Krage <jmank88@gmail.com> - Add chain reader config validation - Add chain reader config validation tests - Add config for chain reader median contract to cr validation testcases - Add unimplemented Encode(), Decode(), GetMaxEncodingSize(), GetMaxDecodingSize() - Add ChainReader() method to mock provider for plugin test - Rename relaymercury.ChainReader to MercuryChainReader, resolve name collisions - Add tests for errors during ChainReader construction - Propagate InvalidConfig & any other errors back to client We should ignore Unimplemented until node ops have been given ample time to migrate to the new job spec (including a section for ChainReader config) so that we can remove the old product-specific MedianContract component from MedianProvider. All other errors we can immediately start passing back to the client, letting the core node decide how to handle them (eg. displaying an "invalid job spec" message to the UI if the RelayConfig was invalid or the ContractID missing)

…er-EVM-POC # Conflicts: # core/services/ocr2/plugins/ocr2vrf/coordinator/coordinator_test.go

core/services/relay/evm/chain_reader.go

cl-sonarqube-production · 2023-12-06T17:08:42Z

SonarQube Quality Gate

63.2% Coverage on New Code (is less than 75%)

See analysis details on SonarQube

* Implement skeleton interfaces, structs, & methods for ChainReader EVM POC - Read ChainReader config in from RelayConfig - Add some initialization and validation relay skeletons - Use medianProviderWrapper instead of passing medianContract separately This avoids us having to modify the signature of NewMedianFactory, which would require further modifications to all non-evm repos and chainlink-relay - Add chain_reader_test.go with some basic relay tests Co-authored-by: Jordan Krage <jmank88@gmail.com> - Add chain reader config validation - Add chain reader config validation tests - Add config for chain reader median contract to cr validation testcases - Add unimplemented Encode(), Decode(), GetMaxEncodingSize(), GetMaxDecodingSize() - Add ChainReader() method to mock provider for plugin test - Rename relaymercury.ChainReader to MercuryChainReader, resolve name collisions - Add tests for errors during ChainReader construction - Propagate InvalidConfig & any other errors back to client We should ignore Unimplemented until node ops have been given ample time to migrate to the new job spec (including a section for ChainReader config) so that we can remove the old product-specific MedianContract component from MedianProvider. All other errors we can immediately start passing back to the client, letting the core node decide how to handle them (eg. displaying an "invalid job spec" message to the UI if the RelayConfig was invalid or the ContractID missing) * Update relay versions * Simplify chain reader config validation * Update commit hashes one final time now that all relays are merged. --------- Co-authored-by: ilija <pavlovicilija42@gmail.com>

reductionista force-pushed the BCF-2612-ChainReader-EVM-POC branch 11 times, most recently from d001287 to 64bf244 Compare October 23, 2023 15:20

ilija42 reviewed Oct 24, 2023

View reviewed changes

core/services/relay/evm/chain_reader.go Outdated Show resolved Hide resolved

reductionista force-pushed the BCF-2612-ChainReader-EVM-POC branch 2 times, most recently from b9f02ca to 0c1c237 Compare October 25, 2023 03:06

reductionista marked this pull request as ready for review October 25, 2023 03:49

reductionista requested review from a team, bolekk, justinkaseman, KuphJr, jmank88 and krehermann as code owners October 25, 2023 03:49

reductionista force-pushed the BCF-2612-ChainReader-EVM-POC branch 2 times, most recently from beac2c8 to e2e0f2d Compare October 27, 2023 00:13