Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[keystone] Normalize ref regex to match id property #13112

Merged
merged 1 commit into from
May 6, 2024
Merged

[keystone] Normalize ref regex to match id property #13112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/ten-dodos-run.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"chainlink": patch
---

#internal Normalize keystone workflow ref regex property to match id regex
2 changes: 1 addition & 1 deletion core/services/workflows/models_yaml.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ type stepDefinitionYaml struct {
// - “ref” has a circular reference.
//
// NOTE: Should introduce a custom validator to cover trigger case
Ref string `json:"ref,omitempty" jsonschema:"pattern=^[a-z0-9_]+$"`
Ref string `json:"ref,omitempty" jsonschema:"pattern=^[a-z0-9_-]+$"`

// Capabilities can specify an additional optional ”inputs” property. It allows specifying a dependency on the result of one or more other capabilities. These are always runtime values that cannot be provided upfront. It takes a map of the argument name internal to the capability and an explicit reference to the values.
//
Expand Down
2 changes: 1 addition & 1 deletion core/services/workflows/testdata/fixtures/workflows/workflow_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
},
"ref": {
"type": "string",
"pattern": "^[a-z0-9_]+$"
"pattern": "^[a-z0-9_-]+$"
},
"inputs": {
"$ref": "#/$defs/mapping"
Expand Down