[KS-193] Pass MercuryTriggerService to Mercury Transmitter #13118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bolekk
commented
May 6, 2024
•
bolekk
commented
- Add EnableTriggerCapability flag to Relay config
- Create MercuryTriggerService lazily, on the first call to NewMercuryProvider()
- Make it available in the Transmitter (no-op for now)
bolekk
commented
May 6, 2024
bolekk
force-pushed
the
feature/KS-140-mercury
branch
from
29957ab
to
a137492
Compare
bolekk
changed the title
bolekk
force-pushed
the
feature/KS-140-mercury
branch
from
a137492
to
48613d5
Compare
bolekk
force-pushed
the
feature/KS-140-mercury
branch
from
48613d5
to
5c0805b
Compare
bolekk
force-pushed
the
feature/KS-140-mercury
branch
from
5c0805b
to
cd14cc2
Compare
bolekk
force-pushed
the
feature/KS-140-mercury
branch
from
cd14cc2
to
b247b40
Compare
bolekk
changed the title
bolekk
force-pushed
the
feature/KS-140-mercury
branch
from
b247b40
to
a385344
Compare
bolekk
force-pushed
the
feature/KS-140-mercury
branch
from
a385344
to
7c982a8
Compare
bolekk
force-pushed
the
feature/KS-140-mercury
branch
from
7c982a8
to
76617f1
Compare
| @@ -179,6 +179,7 @@ type ApplicationOpts struct { | |||
| LoopRegistry *plugins.LoopRegistry | |||
| GRPCOpts loop.GRPCOpts | |||
| MercuryPool wsrpc.Pool | |||
| CapabilitiesRegistry *capabilities.Registry | |||
There was a problem hiding this comment.
Please use coretypes.CapabilitiesRegistry here rather than the concrete type (chainlink-common/pkg/types/core) as that will make loopification easy
| @@ -33,7 +34,8 @@ type RelayerFactory struct { | |||
| logger.Logger | |||
| *plugins.LoopRegistry | |||
| loop.GRPCOpts | |||
| MercuryPool wsrpc.Pool | |||
| MercuryPool wsrpc.Pool | |||
| CapabilitiesRegistry *capabilities.Registry | |||
cedric-cordenier
previously approved these changes
May 8, 2024
bolekk
force-pushed
the
feature/KS-140-mercury
branch
from
76617f1
to
d3a873d
Compare
cedric-cordenier
previously approved these changes
May 8, 2024
1. Add EnableTriggerCapability flag to Relay config 2. Create MercuryTriggerService lazily, on the first call to NewMercuryProvider() 3. Make it available in the Transmitter (no-op for now)
bolekk
force-pushed
the
feature/KS-140-mercury
branch
from
d1964ff
to
36fb4d8
Compare
|
samsondav
approved these changes
May 9, 2024
| @@ -127,21 +127,38 @@ func (s *registrySyncer) Start(ctx context.Context) error { | |||
| } | |||
| if slices.Contains(triggerDONPeers, myId) { | |||
| s.lggr.Info("member of a capability DON - starting remote publishers") | |||
|
|
|||
| { | |||
There was a problem hiding this comment.
Seems weird to have mocks explicitly instantiated in application code, can we not use dependency injection here?
There was a problem hiding this comment.
This Syncer object is soon going to be replaced with a real one.
krehermann
reviewed
May 9, 2024
krehermann
reviewed
May 9, 2024
krehermann
approved these changes
May 9, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced May 9, 2024
akuzni2
pushed a commit
that referenced
this pull request
May 11, 2024
1. Add EnableTriggerCapability flag to Relay config 2. Create MercuryTriggerService lazily, on the first call to NewMercuryProvider() 3. Make it available in the Transmitter (no-op for now)
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 11, 2024
* Fix metric description on mercury_transmit_queue_load * Add changeset * Add changesets tag * Decouple gas tests (#12972) * Add first version of evm utils * Remove unused context util * Add WSServer tests * Add NewLegacyTransaction test * Update NewTestChainScopedConfig to apply correct defaults * Decouple gas package tests from core * Move testutils * Update paths * Fix import error * Add changeset * Add logs to identify when assumptions of log queuing behaviour are violated (#12846) * Add logs to identify when assumptions of log queuing behaviour are violated * Add tests * go import * Add changeset * Update enqueuing assumption * Update tests * Extract block tracking into a separate function * Clean up outdated enqueued blocks * Clean up imports * Ignore reord buffer in cleanup * Cleanup test name * tools/docker: bump postgres to v14 (#13156) * changed spammy error log to debug (#13153) * [KS-186] Add custom OCR3 Capability Provider (#13137) * [KS-193] Pass MercuryTriggerService to Mercury Transmitter (#13118) 1. Add EnableTriggerCapability flag to Relay config 2. Create MercuryTriggerService lazily, on the first call to NewMercuryProvider() 3. Make it available in the Transmitter (no-op for now) * update changeset to include db_update tag (#13170) * fix go-etheruem compatibility pipeline trigger (#13162) * Revert "Add logs to identify when assumptions of log queuing behaviour are violated" (#13173) * Revert "Add logs to identify when assumptions of log queuing behaviour are vi…" This reverts commit 6a342ae. * Add changeset * chore: update solana-build-contracts for node20 (#13175) * chore: update solana-build-contracts for node20 * chore: bump chainlink-solana version * Decouple utils tests from core (#12993) * Add first version of evm utils * Remove unused context util * Add WSServer tests * Add NewLegacyTransaction test * Update NewTestChainScopedConfig to apply correct defaults * Move testutils * Decouple utils tests from core * Add changeset --------- Co-authored-by: Dimitris Grigoriou <dimitris.grigoriou@smartcontract.com> Co-authored-by: ferglor <fergal.gribben@smartcontract.com> Co-authored-by: Jordan Krage <jmank88@gmail.com> Co-authored-by: Patrick <patrick.huie@smartcontract.com> Co-authored-by: Cedric <cedric.cordenier@smartcontract.com> Co-authored-by: Bolek <1416262+bolekk@users.noreply.github.com> Co-authored-by: Chunkai Yang <matYang@users.noreply.github.com> Co-authored-by: Bartek Tofel <bartek.tofel@smartcontract.com> Co-authored-by: Erik Burton <erikburt@users.noreply.github.com>
This was referenced May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.