Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/docker: bump postgres to v14 #13156

Merged
merged 1 commit into from
May 9, 2024
Merged

tools/docker: bump postgres to v14 #13156

merged 1 commit into from
May 9, 2024

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented May 9, 2024

The minimum required version for postgres is 12 now. This PR bumps the tools/docker database to v14.

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@jmank88 jmank88 requested a review from a team May 9, 2024 13:29
Copy link
Collaborator

@pavel-raykov pavel-raykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason the 14 is chosen as a new version and not 16, for example? (e.g., looking at https://www.postgresql.org/support/versioning/ 16 seems like a better choice)

@jmank88
Copy link
Contributor Author

jmank88 commented May 9, 2024

Is there any reason the 14 is chosen as a new version and not 16, for example? (e.g., looking at postgresql.org/support/versioning 16 seems like a better choice)

We have had problems in the past with using the latest version and introducing an accidental dependency on a new feature, so we typically test against older release. Not as important here though, so maybe we could try one node on 12 and the other on 16? 🤷

@jmank88 jmank88 added this pull request to the merge queue May 9, 2024
Merged via the queue into develop with commit 6c0d6b8 May 9, 2024
106 checks passed
@jmank88 jmank88 deleted the tools-docker-pg-14 branch May 9, 2024 14:16
@pavel-raykov
Copy link
Collaborator

Is there any reason the 14 is chosen as a new version and not 16, for example? (e.g., looking at postgresql.org/support/versioning 16 seems like a better choice)

We have had problems in the past with using the latest version and introducing an accidental dependency on a new feature, so we typically test against older release. Not as important here though, so maybe we could try one node on 12 and the other on 16? 🤷

Ok, I am actually fine with any version, I am just trying to understand how to choose it. It seems that some component was updated and it now requires postgres of version >= 12, do we expect that such an update should cause some quality gate to fail?

@jmank88
Copy link
Contributor Author

jmank88 commented May 9, 2024

Ok, I am actually fine with any version, I am just trying to understand how to choose it. It seems that some component was updated and it now requires postgres of version >= 12, do we expect that such an update should cause some quality gate to fail?

It would be better to run this in CI some way to hold us accountable. We just don't use it for anything other than local development currently, so it took a week or two to notice this problem.

akuzni2 pushed a commit that referenced this pull request May 11, 2024
github-merge-queue bot pushed a commit that referenced this pull request May 11, 2024
* Fix metric description on mercury_transmit_queue_load

* Add changeset

* Add changesets tag

* Decouple gas tests (#12972)

* Add first version of evm utils

* Remove unused context util

* Add WSServer tests

* Add NewLegacyTransaction test

* Update NewTestChainScopedConfig to apply correct defaults

* Decouple gas package tests from core

* Move testutils

* Update paths

* Fix import error

* Add changeset

* Add logs to identify when assumptions of log queuing behaviour are violated (#12846)

* Add logs to identify when assumptions of log queuing behaviour are violated

* Add tests

* go import

* Add changeset

* Update enqueuing assumption

* Update tests

* Extract block tracking into a separate function

* Clean up outdated enqueued blocks

* Clean up imports

* Ignore reord buffer in cleanup

* Cleanup test name

* tools/docker: bump postgres to v14 (#13156)

* changed spammy error log to debug (#13153)

* [KS-186] Add custom OCR3 Capability Provider (#13137)

* [KS-193] Pass MercuryTriggerService to Mercury Transmitter (#13118)

1. Add EnableTriggerCapability flag to Relay config
2. Create MercuryTriggerService lazily, on the first call to NewMercuryProvider()
3. Make it available in the Transmitter (no-op for now)

* update changeset to include db_update tag (#13170)

* fix go-etheruem compatibility pipeline trigger (#13162)

* Revert "Add logs to identify when assumptions of log queuing behaviour are violated" (#13173)

* Revert "Add logs to identify when assumptions of log queuing behaviour are vi…"

This reverts commit 6a342ae.

* Add changeset

* chore: update solana-build-contracts for node20 (#13175)

* chore: update solana-build-contracts for node20

* chore: bump chainlink-solana version

* Decouple utils tests from core (#12993)

* Add first version of evm utils

* Remove unused context util

* Add WSServer tests

* Add NewLegacyTransaction test

* Update NewTestChainScopedConfig to apply correct defaults

* Move testutils

* Decouple utils tests from core

* Add changeset

---------

Co-authored-by: Dimitris Grigoriou <dimitris.grigoriou@smartcontract.com>
Co-authored-by: ferglor <fergal.gribben@smartcontract.com>
Co-authored-by: Jordan Krage <jmank88@gmail.com>
Co-authored-by: Patrick <patrick.huie@smartcontract.com>
Co-authored-by: Cedric <cedric.cordenier@smartcontract.com>
Co-authored-by: Bolek <1416262+bolekk@users.noreply.github.com>
Co-authored-by: Chunkai Yang <matYang@users.noreply.github.com>
Co-authored-by: Bartek Tofel <bartek.tofel@smartcontract.com>
Co-authored-by: Erik Burton <erikburt@users.noreply.github.com>
ilija42 pushed a commit that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants