Start inBackupHealthReport during migrations
#13120
Conversation
core/store/migrate/migrate.go
Outdated
| ibhr := services.NewInBackupHealthReport(healthReportPort, lggr) | ||
| ibhr.Start() | ||
| defer ibhr.Stop() |
There was a problem hiding this comment.
Can we do this from the caller instead? Otherwise ensureMigrated is not covered.
There was a problem hiding this comment.
Actually, maybe skip several callers. I think it is important to include as much of the startup time as possible, plus this will avoid the leaking in to the administrative commands that don't need to be reporting health in the first place, like ResetDatabase.
|
I see you added a changeset file but it does not contain a tag. Please edit the text include at least one of the following tags:
|
core/cmd/shell.go
Outdated
There was a problem hiding this comment.
Is just handleNodeVersioning going to be enough? How much time passes between the end of this call and the start of the normal health report?
|
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
george-dorin
deleted the
BCF-3207-start-inBackupHealthReport-on-migrations
branch
InBackupHealthReporttoStartUpHealthReportStartUpHealthReportin thehandleNodeVersioningmethod so it would cover both db migrations and backupsDefaultServeMuxto avoid issues when testing migrations and rollbacks