Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamically set EthGasPriceDefault #1516

Merged
merged 17 commits into from
Aug 12, 2019
Merged

Dynamically set EthGasPriceDefault #1516

merged 17 commits into from
Aug 12, 2019

Conversation

j16r
Copy link
Contributor

@j16r j16r commented Aug 6, 2019 •
edited
Loading

Support setting of the EthGasPriceDefault via remote client.
Supports a --gwei flag for convenience.
Displays change after it is succesfully made.

@j16r j16r force-pushed the feature/dynamic_ethereum_configuration_options branch 2 times, most recently from 0557ae7 to ca5c1c6 Compare August 7, 2019 19:39
@j16r j16r marked this pull request as ready for review August 7, 2019 19:55
dimroc
dimroc suggested changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@dimroc dimroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. All things considered, love the lightweight fix. Few suggestions below.

core/cmd/remote_client.go Outdated Show resolved Hide resolved
core/cmd/remote_client_test.go Show resolved Hide resolved
core/store/orm/config.go Outdated Show resolved Hide resolved
core/store/models/common.go Show resolved Hide resolved
core/store/orm/orm.go Show resolved Hide resolved
@j16r j16r force-pushed the feature/dynamic_ethereum_configuration_options branch from ca5c1c6 to 6b7d3d0 Compare August 9, 2019 16:02
@j16r j16r force-pushed the feature/dynamic_ethereum_configuration_options branch from 6b7d3d0 to c44e217 Compare August 9, 2019 17:17
@j16r j16r merged commit 325b704 into develop Aug 12, 2019
@j16r j16r deleted the feature/dynamic_ethereum_configuration_options branch August 12, 2019 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimroc dimroc dimroc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j16r @dimroc