Remove root level blockchain dependencies #1597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rupurt
force-pushed
the
chore/remove-root-level-blockchain-dependencies
branch
4 times, most recently
from
814853e
to
9c83fa5
Compare
* We now run a locally defined script rather than * directly running the truffle binary. This causes yarn * to resolve to the locally defined version of truffle * within integration/package.json rather than * resolving it via root node_modules lookup, * which would resolve to the wrong truffle version * and would be running it with a cwd of the project * root rather than the package root. This caused * truffle to ignore our locally declared truffle.js config * file, leading to solc version fallback to 0.2.25, when * we wanted 0.2.24
rupurt
force-pushed
the
chore/remove-root-level-blockchain-dependencies
branch
from
9c83fa5
to
57a882e
Compare
typescribe
approved these changes
Sep 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#167720863]