Upgrade to react-static 6

[NavyAdmiral]

There are a lot of breaking changes in 6 so it's not an easy upgrade. I made the dev-server work, but build is still failing. That is the only thing left to fix in this PR.

@rupurt Resize package is not working properly anymore so you might want to take a look. I commented it out as it was making the website crash.

Also @rupurt react-static no longer ships with routing capabilities so we need to start using our own. I added react-router-dom, but couldn't make it fully work yet as it's still failing production build on exporting html. Should we instead use the @reach/router as react-static team recommends?

[rupurt]

@NavyAdmiral awesome cheers 🍺

👍 to @reach/router. It's from the same guy who built a lot of react-router and the API looks fairly similar with a few nice enhancements.

I'll take a deeper look at the PR today.

Also thanks for the input @tannerlinsley 😄

[rupurt]

@NavyAdmiral I think a lot of the failures are due to importing Router from react-static in the tests e.g.

// gui/__tests__/containers/Jobs/Index.test.js
import { Router } from 'react-static'

[NavyAdmiral]

@rupurt Do you have any idea why just switching to @babel/register from babel-register and updating the imports correspondingly isn't enough?

[rupurt]

@NavyAdmiral the geth tests run the e2e tests. You can replicate this by running yarn test-e2e locally. It's failing because the link in the success flash banner is hidden behind the <Header> and can't be clicked by the user.

The incorrect positioning is due to the skipOnMount prop getting set. I took a bit of a look into why that causes the problem but couldn't find a smoking gun at this point and need to time box this. There is an open discussion around something that looks similar to the issue we're running into here.

Also, standard linting errors are unrelated to this PR. They are all over other PRs as well

Check gui tests here https://circleci.com/gh/smartcontractkit/chainlink/14084?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

It looks like the lint task has always been returning a 0 exit code due to snazzy. I've created a new WIP PR to fix it #883

Finally, are there any plans to restructure chainlink? It's already quite heavy. Storybook, truffle, gui, geth, flatteners, solidity, et al, all in 1 package results in unrelated upgrades breaking each other like it did now.

There are currently no plans to restructure the project but we've discussed it. We previously had multiple package.json files but merged them together to get uniform tooling across the project.

[NavyAdmiral]

@rupurt The thing is it used to work fine without skipOnMount and for some reason it broke with this PR. A wild shot at this would be there are some React 16.7 specific changes that broke it. Wilder shot would be it's somehow caused by functional components instead of classes? I'm not quite sure about this because as far as I know both should behave the same unless the class was a <PureComponent/> (which it wasn't before we switched to hooks)

Geth failing is okay as that can be fixed, but I don't know why truffle's failing

[NavyAdmiral]

Package react-use-hooks no longer needed with RS6. Waiting on react-static/react-static#958

[rupurt]

Closing in favor of #919