Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor getting environment variables #299

Closed
justinkaseman opened this issue Feb 4, 2021 · 5 comments
Closed

Refactor getting environment variables #299

justinkaseman opened this issue Feb 4, 2021 · 5 comments

Comments

@justinkaseman
Copy link
Collaborator

justinkaseman commented Feb 4, 2021

Maybe we could avoid some duplication with the other method? Like passing a boolean value e.g = (name: string, required = true, delimiter = ',', prefix = '') and use util.getRandomEnv('API_KEY') in all places.

Then we can call util.getRandomEnv('API_KEY', false) in places that we don't want the var to be required.

Or something similar.

Originally posted by @ebarakos in #226 (comment)

@ebarakos
Copy link
Contributor

ebarakos commented Feb 23, 2021

Tackling this in 08a5e4a (#293)(Dismissed this because it seemed like not providing much value)

@GMSteuart
Copy link

@justinkaseman any reason not to use dotenv

@boxhock
Copy link
Contributor

boxhock commented Jan 18, 2022

@justinkaseman is this still relevant?

@alejoberardino
Copy link
Collaborator

I do think this would be a good change to make, there are many libraries that handle getting env vars and additionally defining a schema to validate them

@justinkaseman
Copy link
Collaborator Author

Closing in favor of EAv3

@justinkaseman justinkaseman closed this as not planned Won't fix, can't repro, duplicate, stale Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants