Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Set mandatory=false for optional response params #3052

Merged
merged 2 commits into from Sep 27, 2019

Conversation

ShobhitAd
Copy link
Contributor

This PR is ready for review.

Risk

This PR makes minor API changes.

Testing Plan

ATF tests

Summary

This PR changes the mandatory attribute for parameters(other than success and resultCode) in RPC responses(in the MOBILE_API) from mandatory=true to mandatory=false.

Currently, core is only guaranteed to return resultCode and success for all RPC responses to mobile. In the case of an error, core may not return other parameters. If those other parameters have mandatory=true in the API spec that could cause issues on the mobile side.

CLA

Copy link
Contributor

@LuxoftAKutsan LuxoftAKutsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShobhitAd I would check SDL code for the usage of these variables.

In some places, the developer may try to get this variable from smart-object without checking if the appropriate key exists, because by API it should be mandatory.

@ShobhitAd ShobhitAd merged commit ec63b3b into develop Sep 27, 2019
@ShobhitAd ShobhitAd deleted the fix/mobile_response_mandatory_params branch September 27, 2019 13:40
@theresalech theresalech added this to Completed Bug Fixes/Enhancements in 6.0.0 Sep 30, 2019
@jacobkeeler jacobkeeler mentioned this pull request Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
6.0.0
Completed Bug Fixes/Enhancements
Development

Successfully merging this pull request may close these issues.

None yet

3 participants