Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/Set mandatory=false for optional response params #3052

Merged
merged 2 commits into from Sep 27, 2019
Merged

Fix/Set mandatory=false for optional response params #3052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
628ad43
Set mandatory=false for all response params(other than resultCode and…
ShobhitAd Sep 25, 2019
5698f44
Add moduleData key check in RCHelpers::RemoveRedundantGPSDataFromIVDa…
ShobhitAd Sep 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/rc_helpers.cc
View file
Open in desktop
Expand Up @@ -257,6 +257,9 @@ void RCHelpers::RemoveRedundantGPSDataFromIVDataMsg(
using namespace application_manager::strings;

LOG4CXX_AUTO_TRACE(logger_);
if (!msg_params.keyExists(kModuleData)) {
return;
}
auto& module_data = msg_params[kModuleData];
if (!module_data.keyExists(kRadioControlData) ||
!module_data[kRadioControlData].keyExists(kSisData) ||
Expand Down
10 changes: 5 additions & 5 deletions src/components/interfaces/MOBILE_API.xml
View file
Open in desktop
Expand Up @@ -6529,7 +6529,7 @@
<description>Provides additional human readable info regarding the result.</description>
</param>

<param name="ecuHeader" type="Integer" minvalue="0" maxvalue="65535" mandatory="true">
<param name="ecuHeader" type="Integer" minvalue="0" maxvalue="65535" mandatory="false">
<description>2 byte ECU Header for DTC response (as defined in VHR_Layout_Specification_DTCs.pdf)</description>
</param>

Expand Down Expand Up @@ -6584,7 +6584,7 @@
<description>Provides additional human readable info regarding the result.</description>
</param>

<param name="messageDataResult" type="Integer" minvalue="0" maxvalue="255" minsize="1" maxsize="65535" array="true" mandatory="true">
<param name="messageDataResult" type="Integer" minvalue="0" maxvalue="255" minsize="1" maxsize="65535" array="true" mandatory="false">
<description>
Array of bytes comprising CAN message result.
</description>
Expand Down Expand Up @@ -7438,7 +7438,7 @@
</function>

<function name="GetInteriorVehicleData" functionID="GetInteriorVehicleDataID" messagetype="response" since="4.5">
<param name="moduleData" type="ModuleData" mandatory="true">
<param name="moduleData" type="ModuleData" mandatory="false">
</param>
<param name="resultCode" type="Result" platform="documentation" mandatory="true">
<description>See Result</description>
Expand Down Expand Up @@ -7540,7 +7540,7 @@

<function name="SetInteriorVehicleData" functionID="SetInteriorVehicleDataID" messagetype="response" since="4.5">
<description>Used to set the values of one remote control module </description>
<param name="moduleData" type="ModuleData" mandatory="true">
<param name="moduleData" type="ModuleData" mandatory="false">
</param>
<param name="resultCode" type="Result" platform="documentation" mandatory="true">
<description>See Result</description>
Expand Down Expand Up @@ -7656,7 +7656,7 @@
</function>

<function name="GetSystemCapability" functionID="GetSystemCapabilityID" messagetype="response" since="4.5">
<param name="systemCapability" type="SystemCapability" mandatory="true">
<param name="systemCapability" type="SystemCapability" mandatory="false">
</param>
<param name="resultCode" type="Result" platform="documentation" mandatory="true">
<description>See Result</description>
Expand Down