Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missed locks #3890

Merged

Conversation

RomanReznichenkoLuxoft
Copy link
Contributor

@RomanReznichenkoLuxoft RomanReznichenkoLuxoft commented Mar 24, 2022

Fixes #3855

This PR is ready for review.

Risk
This PR makes no API changes.

Testing Plan
ATF scripts

Summary
Added missed locks in cash_manager for proprietary mode
Added new mutex for protecting policy table snapshot in policy_manager_impl

CLA

@LitvinenkoIra
Copy link
Contributor

@theresalech This PR is ready for Livio review!

@Jack-Byrne
Copy link
Collaborator

Hello @LitvinenkoIra and @RomanReznichenkoLuxoft. The description mentions missed locks for proprietary and external proprietary policy modes but I do not see any changes to the external policy specific files?

@Jack-Byrne
Copy link
Collaborator

Jack-Byrne commented Mar 28, 2022

Also this test is still failing that was mentioned in this issue comment: #3855 (comment)

Sorry i think i had a bad environment, everything is passing

@Jack-Byrne Jack-Byrne closed this Mar 28, 2022
@Jack-Byrne Jack-Byrne reopened this Mar 28, 2022
@RomanReznichenkoLuxoft
Copy link
Contributor Author

I edited the description. The same changes are already in the external mode on the developer.

@Jack-Byrne Jack-Byrne merged commit b30f012 into smartdevicelink:release/8.1.0 Mar 29, 2022
@OlhaVorobiova OlhaVorobiova deleted the fix/sdl_crash_during_ptu branch June 22, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants