-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/Invalid VR.AddCommand sent during CreateInteractionChoiceSet resumption #3938
Merged
ShobhitAd
merged 5 commits into
develop
from
fix/invalid_vr_addcomand_during_createinteractionchoiseset_resumption
Aug 4, 2022
Merged
Fix/Invalid VR.AddCommand sent during CreateInteractionChoiceSet resumption #3938
ShobhitAd
merged 5 commits into
develop
from
fix/invalid_vr_addcomand_during_createinteractionchoiseset_resumption
Aug 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
jacobkeeler
requested changes
Jul 27, 2022
src/components/application_manager/src/message_helper/message_helper.cc
Outdated
Show resolved
Hide resolved
src/components/application_manager/src/message_helper/message_helper.cc
Outdated
Show resolved
Hide resolved
Ah, another note is that we would need to skip the
Those three changes on their own should solve the issue though |
jacobkeeler
requested changes
Jul 29, 2022
...ts/application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/vr_add_command_request.cc
Outdated
Show resolved
Hide resolved
src/components/application_manager/src/message_helper/message_helper.cc
Outdated
Show resolved
Hide resolved
This reverts commit 2f6b188.
jacobkeeler
requested changes
Aug 4, 2022
…helper.cc Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
jacobkeeler
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3888
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
ATF tests PR submitted for issue
Summary
Modified creation messages for AddCommand DeleteCommand requests
Added check of vr part in VRAddCommandRequest
Added check of grammar_id in VRDeleteCommandRequest
Added unit tests
CLA