Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Invalid VR.AddCommand sent during CreateInteractionChoiceSet resumption #3938

Conversation

ShobhitAd
Copy link
Contributor

Fixes #3888

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

ATF tests PR submitted for issue

Summary

Modified creation messages for AddCommand DeleteCommand requests
Added check of vr part in VRAddCommandRequest
Added check of grammar_id in VRDeleteCommandRequest
Added unit tests

CLA

@jacobkeeler
Copy link
Contributor

jacobkeeler commented Jul 27, 2022

Ah, another note is that we would need to skip the VR.DeleteCommand sending step in delete_interaction_choice_set_request.cc as part of this solution as well.

  if (choice_set.keyExists(strings::grammar_id) &&
      choice_set[strings::grammar_id].asInt() != -1) {
    SendVrDeleteCommand(app);
  } else {
    SendDeleteInteractionChoiceSetResponse();
  }

Those three changes on their own should solve the issue though

…helper.cc

Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
@ShobhitAd ShobhitAd merged commit f8b1dd0 into develop Aug 4, 2022
@ShobhitAd ShobhitAd deleted the fix/invalid_vr_addcomand_during_createinteractionchoiseset_resumption branch August 4, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants