Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accepted] SDL 0107 - New vehicle data - TurnSignal #328

Closed
theresalech opened this issue Nov 8, 2017 · 4 comments
Closed

[Accepted] SDL 0107 - New vehicle data - TurnSignal #328

theresalech opened this issue Nov 8, 2017 · 4 comments

Comments

@theresalech
Copy link
Contributor

theresalech commented Nov 8, 2017

Hello SDL community,

The review of "New vehicle data - TurnSignal" begins now and runs through November 14, 2017. The proposal is available here:

https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0107-New-vehicle-data-turnSignal.md

Reviews are an important part of the SDL evolution process. All reviews should be sent to the associated Github issue at:

#328

What goes into a review?

The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of SDL. When writing your review, here are some questions you might want to answer in your review:

  • Is the problem being addressed significant enough to warrant a change to SDL?
  • Does this proposal fit well with the feel and direction of SDL?
  • If you have used competitors with a similar feature, how do you feel that this proposal compares to those?
  • How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
    Please state explicitly whether you believe that the proposal should be accepted into SDL.

More information about the SDL evolution process is available at

https://github.com/smartdevicelink/sdl_evolution/blob/master/process.md

Thank you,
Theresa Lech

Program Manager - Livio
theresa@livio.io

@Jack-Byrne
Copy link
Contributor

Instead of using the enum "BOTH", wouldn't naming it something like "HAZARDS" be more descriptive?

@joeljfischer
Copy link
Contributor

@JackLivio It might be more semantic to what's happening, but I think it's less descriptive to name it hazards. I can't think of another case where both signals might be enabled, but I think most developers should be able to figure out that if both are on, it's likely a hazard situation. I'm fine with either option, but would lean toward the proposal's.

@theresalech theresalech changed the title [In Review] SDL 0107 - New vehicle data - TurnSignal [Accepted] SDL 0107 - New vehicle data - TurnSignal Nov 15, 2017
@theresalech
Copy link
Contributor Author

The Steering Committee fully agreed to accept this proposal.

@smartdevicelink smartdevicelink locked and limited conversation to collaborators Nov 15, 2017
@theresalech
Copy link
Contributor Author

Issues Entered:
iOS
Android
Core
RPC

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants