Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choice Set Present followed directly by a Delete can have undefined behavior #2020

Closed
joeljfischer opened this issue Jul 8, 2021 · 1 comment · Fixed by #2019
Closed
Assignees
Labels
bug A defect in the library manager-screen Relating to the manager layer - screen managers
Projects

Comments

@joeljfischer
Copy link
Contributor

Bug Report

In certain cases, a present can happen when the choices are not available on the head unit. The present operation should double-check when it starts that all cells are preloaded on the head unit. When a present the operation should be created along with the preload, and updated when the preload finishes. That way the delete will be slotted after the present.

Reproduction Steps
  1. Send a present with a large number of choices
  2. Immediately send a delete for several of those choices
Expected Behavior

The delete happens after the present

Observed Behavior

Undefined error behavior

OS & Version Information
  • iOS Version: n/a
  • SDL iOS Version: v7.3.0-develop
  • Testing Against: n/a
Test Case, Sample Code, and / or Example App

See SDLChoiceSetManagerSpec L432 commented out test

@joeljfischer joeljfischer added bug A defect in the library manager-screen Relating to the manager layer - screen managers labels Jul 8, 2021
@joeljfischer joeljfischer self-assigned this Jul 8, 2021
@joeljfischer joeljfischer added this to To do in v7.3.0 via automation Jul 8, 2021
@joeljfischer joeljfischer linked a pull request Jul 22, 2021 that will close this issue
4 tasks
v7.3.0 automation moved this from To do to Done Sep 17, 2021
@joeljfischer joeljfischer mentioned this issue Sep 27, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library manager-screen Relating to the manager layer - screen managers
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants