-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Choice Set Manager to Fix Several Bugs #2019
Conversation
* Pending presentations are now enqueued and canceled as needed * When a presentation fails, the request itself will now be printed
* Fix tests
* Fix updating cells unique names based on what's already on the head unit
* Add tests
if (![windowCapability hasImageFieldOfName:SDLImageFieldNameChoiceImage]) { | ||
cell.artwork = nil; | ||
} | ||
if (![windowCapability hasTextFieldOfName:SDLTextFieldNameSecondaryText]) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should you use methods like sdl_shouldSendChoiceSecondaryTextBasedOnWindowCapability
here instead of checking the windowCapability directly since it does the same thing?
This needs to fix rollovers of choice ids, check based on existing choice ids, and error if there's no more ids |
* Remove unused parameter from method
* Fixes a bug with pre-fall 2021 HMIs (smartdevicelink/generic_hmi@b292fbb)
* Don't attempt to upload duplicate artworks
Fixes #2018, #2020, #2025
Risk
This PR makes no API changes.
Testing Plan
Unit Tests
Unit tests updated and rewritten
Core Tests
Core version / branch / commit hash / module tested against: Manticore (SDL v7.1.1), Sync Gen 3.4
HMI name / version / branch / commit hash / module tested against: Manticore (Generic HMI v0.10.0), Sync Gen 3.4
Summary
Changelog
Bug Fixes
Tasks Remaining:
Done
CLA