Implement Revisions - SDL 0099 New remote control modules, SDL 0175 Updating DOP value range for GPS notification #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrapitis
force-pushed
the
feature/SDL-0099-remote-control-light-audio-revise
branch
from
a29fb4b
to
86a63d6
Compare
|
@mrapitis I'm seeing unit tests fail to compile due to an import of an old file ( |
2 tasks
|
@joeljfischer we have removed remaining references to GPSLocation. Please re-review when time permits. Thanks! |
…io-revise # Conflicts: # SmartDeviceLink-iOS.xcodeproj/project.pbxproj
joeljfischer
approved these changes
Aug 15, 2018
|
@joeljfischer we have updated the PR to include latest proposal corrections for https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0099-new-remote-control-modules-and-parameters.md From: To: Please re-review when time permits. Thanks! |
joeljfischer
approved these changes
Aug 23, 2018
|
@mrapitis I have a few additional notes:
|
…io-revise # Conflicts: # SmartDeviceLinkTests/RPCSpecs/StructSpecs/SDLRadioControlDataSpec.m
mrapitis
force-pushed
the
feature/SDL-0099-remote-control-light-audio-revise
branch
from
07b26fd
to
ac9245d
Compare
|
@joeljfischer PR has been updated with provided notes. Please re-review when time permits. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1003, #755
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
Added new unit tests and expanded existing ones
Summary
Updated RPC's, structs, enums as defined in Revise New remote control modules proposal:
smartdevicelink/sdl_evolution#572
&
Updating DOP value range for GPS notification proposal:
smartdevicelink/sdl_evolution#577
For simplicity of review, issues have been combined into single PR as changes are dependent on each other.
CLA