-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put SDL queues at the highest priority #1833
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1833 +/- ##
========================================
Coverage 84.65% 84.65%
========================================
Files 418 418
Lines 20971 20977 +6
========================================
+ Hits 17753 17759 +6
Misses 3218 3218 |
This PR did not break anything, however, the responsiveness of the soft buttons on SYNC 3.0 did not improve for me. I noticed in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some investigating and I think I might have found the issue...
@rbright55 Can you please try this PR to see if it resolves your issue (#1778)? Thanks! |
Fixes #1778
Risk
This PR makes no API changes.
Testing Plan
Unit Tests
No unit tests were needed
Core Tests
Verified lots of screen manager behavior with SDL Core. Slight improvements are possible, but it's not super easy to tell, especially if testing against Sync.
Core version / branch / commit hash / module tested against: Sync Gen 3.4
HMI name / version / branch / commit hash / module tested against: Sync Gen 3.4
Summary
This update moves SDL queues to be at the highest priority level instead of the second-highest priority level, and additionally changes the soft button operations to always send
Show.mainField1
even if it should be blank.Changelog
Bug Fixes
Show.mainField1
, which works around a bug on Ford Sync head units.Tasks Remaining:
CLA