Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDL 0021] Remove SDLTTSChunkFactory #488

Merged
merged 1 commit into from
Jan 17, 2017
Merged

[SDL 0021] Remove SDLTTSChunkFactory #488

merged 1 commit into from
Jan 17, 2017

Conversation

asm09fsu
Copy link
Contributor

Fixes #486

This PR is ready for review.

Risk

This PR makes major API changes.

Summary

This PR removes SDLTTSChunkFactory from the project. There were equivalent initialization methods added in 4.4.

Changelog

Breaking Changes
  • Removed SDLTTSChunkFactory from the project.

@asm09fsu asm09fsu added best practice Not a defect but something that should be improved anyway enhancement proposal Accepted SDL Evolution Proposal labels Jan 12, 2017
@asm09fsu asm09fsu added this to the 5.0.0 milestone Jan 12, 2017
@joeljfischer joeljfischer merged commit 9363951 into develop Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeljfischer joeljfischer joeljfischer approved these changes

@aarotar aarotar Awaiting requested review from aarotar

Assignees
No one assigned
Labels
best practice Not a defect but something that should be improved anyway proposal Accepted SDL Evolution Proposal
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@asm09fsu @joeljfischer