Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2 [SDL-0234] Proxy Library RPC Generation #105

Merged
merged 20 commits into from
Jan 31, 2020
Merged

#2 [SDL-0234] Proxy Library RPC Generation #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
ba19354
#2 [SDL-0234] Proxy Library RPC Generation
vladmu Jan 14, 2020
aa30209
Pointed `lib/rpc_spec` submodule to the personal fork for testing pur…
vladmu Jan 15, 2020
2e90da7
refactoring according to comments in pull/202
o-mishch Jan 16, 2020
604bc1b
align changes from parser rpc_spec
o-mishch Jan 21, 2020
8d452a6
align with rpc_spec
o-mishch Jan 23, 2020
a227a48
minor chnages after code review
o-mishch Jan 23, 2020
3d33e2a
Fixed typo 'decription'->'description'
vladmu Jan 24, 2020
325bc23
improve manual mapping
o-mishch Jan 27, 2020
b30da93
Added `Custom mapping` section into README.md
vladmu Jan 28, 2020
34ef524
Minor fix of customization spec
vladmu Jan 28, 2020
e05d423
adding RpcCreator processing
o-mishch Jan 29, 2020
6821ddf
adding RpcCreator.js: year in Copyright
o-mishch Jan 29, 2020
f3f5656
updating auto-tests
o-mishch Jan 29, 2020
904a7c5
Trailing spaces not allowed in RpcCreator
o-mishch Jan 29, 2020
dd8291c
resolving issue with GenericResponseResponce
o-mishch Jan 29, 2020
e0eac24
handle exeption in xsd
o-mishch Jan 30, 2020
ae6dd2b
applying changes requested in review
o-mishch Jan 31, 2020
59df96a
updating .eslintrc
o-mishch Jan 31, 2020
cb10518
Add generated files and update the library and example apps
crokita Jan 31, 2020
f03db6d
Resolve merge conflicts
crokita Jan 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
4 changes: 2 additions & 2 deletions .eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"curly": [ "error" ],
"dot-notation": [ "error" ],
"eqeqeq": [ "error" ],
"id-length": [ "error" ],
"id-length": [ "error", { "exceptions": ["x", "y", "c"] } ],
"indent": [
"error",
4,
Expand All @@ -53,7 +53,7 @@
"error",
"unix"
],
"new-cap": [ "error", {
"new-cap": [ "error", {
"newIsCapExceptions": ["tClass"]
}],
"no-case-declarations": [ "error" ],
Expand Down
8 changes: 7 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
**/node_modules/
*.log
.env
.*env*
.idea
*__pycache__
.DS_Store
*htmlcov
*.coverage
*.pytest_cache
4 changes: 4 additions & 0 deletions .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
[submodule "lib/rpc_spec"]
path = lib/rpc_spec
url = https://github.com/smartdevicelink/rpc_spec.git
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crokita you pointed the submodule to the correct repository, but please take into account the master branch of rpc_spec doesn't contain the parser code yet. The corresponding PR is not merged yet. It would be good if you notify @JackLivio in answer to this comment that JS generator passed your checks and rpc_spec could be merged too.

branch = master
2 changes: 1 addition & 1 deletion examples/js/hello-sdl/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
}

async _onHmiStatusListener (onHmiStatus) {
const hmiLevel = onHmiStatus.getHMILevel();
const hmiLevel = onHmiStatus.getHmiLevel();

// wait for the FULL state for more functionality
if (hmiLevel === SDL.rpc.enums.HMILevel.HMI_FULL) {
Expand Down
2 changes: 1 addition & 1 deletion examples/node/hello-sdl/AppClient.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ class AppClient {
}

async _onHmiStatusListener (onHmiStatus) {
const hmiLevel = onHmiStatus.getHMILevel();
const hmiLevel = onHmiStatus.getHmiLevel();

// wait for the FULL state for more functionality
if (hmiLevel === SDL.rpc.enums.HMILevel.HMI_FULL) {
Expand Down
Loading