[deconz] Added support for publishing ChannelDescriptionChangedEvents #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cweitkamp
commented
Jun 21, 2021
...g.deconz/src/main/java/org/smarthomej/binding/deconz/internal/handler/GroupThingHandler.java
Show resolved
Hide resolved
J-N-K
reviewed
Jun 21, 2021
...org.smarthomej.binding.deconz/src/main/java/org/smarthomej/binding/deconz/internal/Util.java
Outdated
Show resolved
Hide resolved
|
Can you rebase on 3.2.x? We can't merge this to main because the new methods and fields are not available in OHC 3.0.x. I tried just changing the base branch but that resulted in a very big changeset. |
J-N-K
previously approved these changes
Jun 22, 2021
cweitkamp
force-pushed
the
feature-deconz-command-description-changed-events
branch
from
c09c42a
to
e6f6af2
Compare
Done. |
|
bundles/org.smarthomej.binding.deconz/src/main/java/org/smarthomej/binding/deconz/internal/DeconzDynamicStateDescriptionProvider.java:[77,55] Potential null pointer access: this expression has a '@nullable' type @cweitkamp, can you fix that? |
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> Use name for value and label of CommandOption Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> Incorporated comments from review Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
cweitkamp
force-pushed
the
feature-deconz-command-description-changed-events
branch
from
37dae6d
to
153aec8
Compare
Done. |
J-N-K
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChannelDescriptionChangedEventsRelated to openhab/openhab-core#1505
Depends on openhab/openhab-core#2410
Signed-off-by: Christoph Weitkamp github@christophweitkamp.de