[viessmann] fix setTargetTemperature and setCurve #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogrun
commented
Aug 22, 2022
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
…the transformation (smarthomej#385) * Allow to use an alternative Item State as value for the transformation * Convert source value and operand to QuantityType to allow proper unit calculations Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
Signed-off-by: Jan N. Klug <github@klug.nrw> Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
…homej#391) Signed-off-by: Cody Cutrer <cody@cutrer.us> Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
* [amazonechocontrol] improve request handling Signed-off-by: Jan N. Klug <github@klug.nrw> Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
Signed-off-by: Jan N. Klug <github@klug.nrw> Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
* [telenot] add serialport bridge * [telenot] fix msg reading * [telenot] fix power outage msg * [telenot] add timeout for sending the command Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
rogrun
force-pushed
the
3.2.x-viessmann-WIP-handle-setCurve
branch
from
f65a6b5
to
22ec4c2
Compare
|
@rogrun Thanks for your contribution. I‘m not sure why this happened, but can you please rebase on main branch? There are some changes which do not belong here. |
cweitkamp
reviewed
Aug 25, 2022
...viessmann/src/main/java/org/smarthomej/binding/viessmann/internal/handler/DeviceHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
…com/rogrun/addons into 3.2.x-viessmann-WIP-handle-setCurve
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
|
@cweitkamp please review the requested changes |
cweitkamp
previously approved these changes
Sep 2, 2022
...viessmann/src/main/java/org/smarthomej/binding/viessmann/internal/handler/DeviceHandler.java
Outdated
Show resolved
Hide resolved
...viessmann/src/main/java/org/smarthomej/binding/viessmann/internal/handler/DeviceHandler.java
Outdated
Show resolved
Hide resolved
...viessmann/src/main/java/org/smarthomej/binding/viessmann/internal/handler/DeviceHandler.java
Outdated
Show resolved
Hide resolved
...viessmann/src/main/java/org/smarthomej/binding/viessmann/internal/handler/DeviceHandler.java
Show resolved
Hide resolved
|
@J-N-K There is another bug when setting the comfort temperature. Please wait before merging this PR. I will report when I have finished my work. |
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
for operating program Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
|
@cweitkamp please test and review the fix for setTemperature. Thanks. |
J-N-K
reviewed
Sep 4, 2022
bundles/org.smarthomej.binding.viessmann/src/main/resources/update/device.update
Show resolved
Hide resolved
|
The features I am looking for are working right now. Very much appreciated. Thanks. |
J-N-K
approved these changes
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two bugs:
Reported here in the community https://community.openhab.org/t/binding-smarthome-j-viessmann-binding-cant-set-value/137205
@cweitkamp: Please review these changes, thanks
Signed-off-by: Ronny Grun ronny.grun@t-online.de