Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

telegram: Plugin should be improved to use async #708

Closed
bmxp opened this issue Mar 8, 2023 · 2 comments
Closed

telegram: Plugin should be improved to use async #708

bmxp opened this issue Mar 8, 2023 · 2 comments
Milestone
Version 1.10

Comments

@bmxp
Copy link
Member

bmxp commented Mar 8, 2023

The telegram plugin uses threads currently. As the underlying telegram lib will only be improved at async being version > 20.x we should consider a move to async and use newer lib then.
@msinn msinn modified the milestones: Version 1.10, Version 1.8 Mar 9, 2023
@ivan73
Copy link
Contributor

ivan73 commented Apr 15, 2023

Maybe someone can take a look before I make the pull request?
https://github.com/ivan73/plugins/blob/develop/telegram/__init__.py

@msinn msinn changed the title telegram plugin should be improved to use async telegram: Plugin should be improved to use async Sep 2, 2023
@bmxp
Copy link
Member Author

bmxp commented Sep 6, 2023

The code was merged into develop back in April and since tested successfully together with some enhancements.

@bmxp bmxp closed this as completed Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 1.10
Development

No branches or pull requests
3 participants
@msinn @bmxp @ivan73