Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gemspec to allow Rails5 #344

Closed

Conversation

akito19
Copy link

@akito19 akito19 commented Jul 1, 2016

Hi!

When I upgraded to Rails5.0 in my project, exception_notification said

$ bundle update rails
Fetching gem metadata from https://rubygems.org/
Fetching version metadata from https://rubygems.org/
Fetching dependency metadata from https://rubygems.org/
Resolving dependencies.........
Bundler could not find compatible versions for gem "actionmailer":
  In Gemfile:
    exception_notification was resolved to 4.1.4, which depends on
      actionmailer (~> 4.0)

So I rewrote exception_notification.gemspec and added /gemfiles/rails5_0.gemfile.
Thank you!

@coveralls
Copy link

coveralls commented Jul 1, 2016

Coverage Status

Coverage remained the same at 94.216% when pulling 01fe8d7 on akito19:fix_gemspec_to_upgrade_rails_version into 4d6adef on smartinez87:master.

@coveralls
Copy link

coveralls commented Jul 1, 2016

Coverage Status

Coverage decreased (-0.7%) to 93.563% when pulling ae1f86e on akito19:fix_gemspec_to_upgrade_rails_version into 4d6adef on smartinez87:master.

@coveralls
Copy link

coveralls commented Jul 1, 2016

Coverage Status

Coverage decreased (-0.7%) to 93.47% when pulling 2c2e1a4 on akito19:fix_gemspec_to_upgrade_rails_version into 4d6adef on smartinez87:master.

@coveralls
Copy link

coveralls commented Jul 1, 2016

Coverage Status

Coverage decreased (-0.7%) to 93.47% when pulling 2c2e1a4 on akito19:fix_gemspec_to_upgrade_rails_version into 4d6adef on smartinez87:master.

@smartinez87
Copy link
Owner

thanks @akito19 for your work! We just merged #306, so I'll close this one

@smartinez87 smartinez87 closed this Jul 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants