Skip to content

Commit

Permalink
MONKEY PATCH: Remove check which fails with .domain.com cookies
Browse files Browse the repository at this point in the history
There has been an open issue in cookiejar Gem since 2014.
The project seems unmaintained, but it's used by the faye gem.

References:
* restforce/restforce#120
* dwaite#19
* dwaite#23
  • Loading branch information
pre committed May 17, 2018
1 parent c02007c commit d25b372
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions lib/cookiejar/cookie_validation.rb
Original file line number Diff line number Diff line change
Expand Up @@ -261,9 +261,10 @@ def self.validate_cookie(request_uri, cookie)
# The request-host is a HDN (not IP address) and has the form HD,
# where D is the value of the Domain attribute, and H is a string
# that contains one or more dots.
unless domains_match cookie_host, uri
errors << 'Domain is inappropriate based on request URI hostname'
end
## MONKEY PATCH: this fails with .salesforce.com
## unless domains_match cookie_host, uri
## errors << 'Domain is inappropriate based on request URI hostname'
## end

# The Port attribute has a "port-list", and the request-port was
# not in the list.
Expand Down

0 comments on commit d25b372

Please sign in to comment.