Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

Handle TabBar #8

Open
Topener opened this issue Feb 2, 2016 · 4 comments
Open

Handle TabBar #8

Topener opened this issue Feb 2, 2016 · 4 comments

Comments

@Topener
Copy link

Topener commented Feb 2, 2016

would be great if TabBar can be handled properly.

With native code this is easy, but with a module a little less. Is there a way to add a flag so it can be handled in a tabbar too?

Issue here: danielamitay/DAKeyboardControl#42

@yuchi
Copy link
Member

yuchi commented Feb 2, 2016

The best way I can think of is to add a lockedViewsMinOffset property to be used at this line to manage a minimum value it must have.

Would you mind to make the changes? I’ll gladly accept them.


Thank you for using this module!!

@Topener
Copy link
Author

Topener commented Feb 2, 2016

Yeah that sounds like a great addition.

But I'm afraid I don't have any knowledge of Obj-c, and I'd like to change it but not the time to do it just now...

@macasfaj
Copy link

I would like to update the module and send a PR, but I can't clone the full project. I get this

`Cloning into '/Users/Migue/Documents/NubecitaSVN/TiDAKeyboardControl/DAKeyboardControl'...
Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
fatal: clone of 'git@github.com:danielamitay/DAKeyboardControl.git' into submodule path '/Users/Migue/Documents/NubecitaSVN/TiDAKeyboardControl/DAKeyboardControl' failed
Failed to clone 'DAKeyboardControl'. Retry scheduled
Cloning into '/Users/Migue/Documents/NubecitaSVN/TiDAKeyboardControl/DAKeyboardControl'...`

@yuhi can you check it? Thanks.

@yuchi
Copy link
Member

yuchi commented Jul 25, 2017

There could be some problems with the git submodule. Thanks for caring @macasfaj, I’ll have a look soon.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants