fix: add CSVWithNames to supported formats #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to add some test cases for this feature |
|
@2ur1st thanks for response! Did I get it right, you need actual CH database to run unit tests with this library? |
|
@Phrlog yes, the library contain a lot of tests and there are not only unit tests |
2ur1st
reviewed
Nov 26, 2018
| @@ -12,8 +12,9 @@ class WriteToFile | |||
| const FORMAT_TabSeparated = 'TabSeparated'; | |||
| const FORMAT_TabSeparatedWithNames = 'TabSeparatedWithNames'; | |||
| const FORMAT_CSV = 'CSV'; | |||
| const FORMAT_CSVWithNames = 'CSVWithNames'; | |||
There was a problem hiding this comment.
You must use upper case for constants, I know you wrote code like another constants, but its legacy and its not correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://clickhouse.yandex/docs/en/interfaces/formats/#csvwithnames