Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

Callout card illustration is missing alt text #267

Closed
matt-neill opened this issue Dec 17, 2018 · 3 comments
Closed

Callout card illustration is missing alt text #267

matt-neill opened this issue Dec 17, 2018 · 3 comments
Labels
enhancement New feature or request

Comments

@matt-neill
Copy link

Problem

Missing alt text in the <img /> tag of the callout card (line 39)

Solution

Add some alt text, yo

@matt-neill matt-neill added the enhancement New feature or request label Dec 17, 2018
@andrewpye
Copy link
Member

@matt-neill closing this as this is the aim of ember-polaris is to match the behaviour of the Shopify React implementation in Ember-land, and their implementation of this also has a hard-coded empty alt attribute on the image.

@vladucu
Copy link
Member

vladucu commented Dec 18, 2018

@andrewpye what do you think of opening an issue/PR for this with Shopify?

@andrewpye
Copy link
Member

Could do... waiting to hear from @matt-neill what the use case was first. I guess Shopify had their reasons for setting a blank alt value when they originally built the component 🤷‍♂️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants