Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.5 compatibility #25

Closed
rhaarm opened this issue Mar 22, 2016 · 1 comment
Closed

Python 3.5 compatibility #25

rhaarm opened this issue Mar 22, 2016 · 1 comment

Comments

@rhaarm
Copy link

rhaarm commented Mar 22, 2016

Does the current state of the api support Python 3.5? I forked this and plan to make updates to possibly support async from PY35, if time permits!

@smiley
Copy link
Owner

smiley commented Mar 22, 2016

Great idea! I thought to implement this with Requests' async capabilities, but couldn't find the time to keep working on it. (And then Python 3.5 was released)

There shouldn't be any compatibility issues. The package used to be incompatible with Python 3.x due to some backwards-incompatible changes in 3.x (see #16 & #18), but it should work now.

Async is awesome, but it shouldn't break compatibility with <3.5. If you can't work a single solution for 2.7 - 3.5, you can create a shim at _shims in core.py for version-dependent behaviour.

@smiley smiley changed the title Python 3.5 Python 3.5 compatibility Apr 16, 2016
@smiley smiley closed this as completed Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants