Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving TIFF image raises Value error #610

Closed
jrief opened this issue Oct 17, 2022 · 2 comments
Closed

Saving TIFF image raises Value error #610

jrief opened this issue Oct 17, 2022 · 2 comments

Comments

@jrief
Copy link
Collaborator

jrief commented Oct 17, 2022

On attempt to save an image of type TIFF PIL raises a ValueError complaining with: "quality setting only supported for 'jpeg' compression".

This can easily be prevented removing the quality key from the options dictionary.

I already prepared a patch for this issue.

@jrief jrief closed this as completed in c75a281 Jan 8, 2023
@jrief
Copy link
Collaborator Author

jrief commented Jan 9, 2023

Unfortunately I introduced a regression in version 2.8.4. I tried to revert this, but now running
the unit tests fails. This presumably is because GitHub changed something in their action
scripts. Please check the "Install dependencies" section in those two jobs

https://github.com/SmileyChris/easy-thumbnails/actions/runs/3696468077/jobs/6260204110

https://github.com/SmileyChris/easy-thumbnails/actions/runs/3866392805/jobs/6590486709

what's the difference?

Therefore I'd like to propose to replace tox by GitHub's own matrix runner. I do that in
all of my projects, and in my opinion that's a better approach.

What do you think?

@mireq
Copy link
Contributor

mireq commented Jan 9, 2023

Problem is in setup.py on this line:

version=easy_thumbnails.get_version(),

Previous version imported get_version from

def get_version(*args, **kwargs):

But now is imported file easy_thumbnails/get_version.py as module instead of function. Either get_version function should be renamed to something unique like get_package_version or module get_version should be renamed to prevent name conflict.

@jrief jrief closed this as completed in 2e867b1 Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants