Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Okmeter tag format #33

Closed
doc-sheet opened this issue Sep 22, 2023 · 5 comments
Closed

Okmeter tag format #33

doc-sheet opened this issue Sep 22, 2023 · 5 comments

Comments

@doc-sheet
Copy link

doc-sheet commented Sep 22, 2023

Hello!
Could you add an okmeter tag support?
I guess I can't simply use basic TagFormat because separator is a string _is_

@smira
Copy link
Owner

smira commented Sep 25, 2023

Looks like tags are sent as part of the metric name, so the library itself doesn't have to be changed?

You can just send "value.tag_is_value" and everything is good? If needed, you can make a wrapper for syntactic sugar?

@doc-sheet
Copy link
Author

doc-sheet commented Sep 26, 2023

You can just send "value.tag_is_value" and everything is good? If needed, you can make a wrapper for syntactic sugar?

Indeed. It's a common workaround, I just wanted to use standart method for tags.
Could you maybe change type of KeyValueSeparator to string or []byte?

@smira
Copy link
Owner

smira commented Sep 26, 2023

if you have a PR, I could take a look. Please keep in mind it should be optimized for low memory allocations in either case.

@doc-sheet
Copy link
Author

Sure.
I try golang for like less then a week, but here is my proposal #34

@doc-sheet
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants